Fix GitHub Actions build errors and Node.js deprecation warnings

- Remove unused orderCosts parameter from createExpensesFromCsvData function
- Update function call to match new signature
- Upgrade GitHub Actions to use Node.js 24 instead of deprecated Node.js 20
- Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 environment variable

This should resolve the build failure and deprecation warnings in CI/CD.
This commit is contained in:
dlawler489 2026-05-05 18:37:29 +10:00
parent a36582b843
commit e89bb8e0d4
2 changed files with 3 additions and 3 deletions

View file

@ -10,6 +10,7 @@ on:
env:
REGISTRY: ghcr.io
IMAGE_NAME: ${{ github.repository }}
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
jobs:
build-and-push:
@ -25,7 +26,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '24'
cache: 'npm'
cache-dependency-path: |
client/package-lock.json

View file

@ -113,7 +113,6 @@ export default function DataImport() {
// Create expenses from CSV import data
const createExpensesFromCsvData = async (
orderCosts: ImportResults['orderCosts'],
shippingRecords: ParsedShippingRecord[],
etsyFees: EtsyFeeRecord[]
) => {
@ -294,7 +293,7 @@ export default function DataImport() {
dispatch(setOrders(ordersRes.data.orders));
// Create expenses from CSV data
await createExpensesFromCsvData(orderCosts, shippingRecords, etsyFees);
await createExpensesFromCsvData(shippingRecords, etsyFees);
toast.success(`CSV imported! Created ${res.data.created} new orders and updated ${res.data.updated} existing orders.`);
} catch {