From e89bb8e0d4245ab68fa44d2b981df9d8cd6c8bef Mon Sep 17 00:00:00 2001
From: dlawler489 <104159223@student.swin.edu.au>
Date: Tue, 5 May 2026 18:37:29 +1000
Subject: [PATCH] Fix GitHub Actions build errors and Node.js deprecation
 warnings

- Remove unused orderCosts parameter from createExpensesFromCsvData function
- Update function call to match new signature
- Upgrade GitHub Actions to use Node.js 24 instead of deprecated Node.js 20
- Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 environment variable

This should resolve the build failure and deprecation warnings in CI/CD.
---
 .github/workflows/docker-build.yml | 3 ++-
 client/src/pages/DataImport.tsx    | 3 +--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/docker-build.yml b/.github/workflows/docker-build.yml
index 2865cd7..94cbd5a 100644
--- a/.github/workflows/docker-build.yml
+++ b/.github/workflows/docker-build.yml
@@ -10,6 +10,7 @@ on:
 env:
   REGISTRY: ghcr.io
   IMAGE_NAME: ${{ github.repository }}
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
 
 jobs:
   build-and-push:
@@ -25,7 +26,7 @@ jobs:
     - name: Set up Node.js
       uses: actions/setup-node@v4
       with:
-        node-version: '18'
+        node-version: '24'
         cache: 'npm'
         cache-dependency-path: |
           client/package-lock.json
diff --git a/client/src/pages/DataImport.tsx b/client/src/pages/DataImport.tsx
index 8486b36..a81ea96 100644
--- a/client/src/pages/DataImport.tsx
+++ b/client/src/pages/DataImport.tsx
@@ -113,7 +113,6 @@ export default function DataImport() {
 
   // Create expenses from CSV import data
   const createExpensesFromCsvData = async (
-    orderCosts: ImportResults['orderCosts'], 
     shippingRecords: ParsedShippingRecord[],
     etsyFees: EtsyFeeRecord[]
   ) => {
@@ -294,7 +293,7 @@ export default function DataImport() {
         dispatch(setOrders(ordersRes.data.orders));
         
         // Create expenses from CSV data
-        await createExpensesFromCsvData(orderCosts, shippingRecords, etsyFees);
+        await createExpensesFromCsvData(shippingRecords, etsyFees);
         
         toast.success(`CSV imported! Created ${res.data.created} new orders and updated ${res.data.updated} existing orders.`);
       } catch {